ThomHehl / Moffatt

The Moffat Bible
1 stars 1 forks source link

Quotations #7

Open ThomHehl opened 6 years ago

ThomHehl commented 6 years ago

@DavidHalsam The OSIS tag for quotes includes a speaker, which indicates to me that it is intended for all quotes. If so, then what is the corresponding USFM tag to that and that allows for nested quotes as OSIS does?

DavidHaslam commented 6 years ago

@ThomHehl

Many aspects of OSIS XML are optional rather than mandatory.

The OSIS q element has an attribute who="person". Except for words of Jesus (in red letter editions), in practice it's rarely used. Conversion from USFM \wj ...\wj* should result in <q who="Jesus">...</q>.

This is quite distinct from the speaker element that's sometimes used in Job and Song of Songs.

DavidHaslam commented 6 years ago

@ThomHehl

USFM files should only use the \qt_...\qt* special character markers for quotations from someone or something. e.g. NT quotations from the OT.

They are not to be used for every instance of speech.

There is no such marker pair as \qt1...\qt1* in USFM 2.4 but this changed with USFM 3.0.

NB. All USFM start tags must include a space before the first character of the text.

If Moffatt (like the AV) made no use of quotation marks, no special markup is required for ordinary speech.

DavidHaslam commented 6 years ago

@ThomHehl

Admittedly, this means that converting USFM to OSIS will not thereby automatically generate any q elements for speech.

So what to do for all those places in USFM where you have the incorrect tags?

DavidHaslam commented 6 years ago

@ThomHehl

It seems to be the case that USFM 3.0 now introduces changes with regard to quotation markers.

See https://ubsicap.github.io/usfm/milestones/index.html

It seems from the two examples used to illustrate \qt#-s\* ... \qt#-e\* that the \qt marker has not only been enhanced to allow the milestone form, but widened in scope in two more ways:

screenshot 2018-01-03 12 22 46

screenshot 2018-01-03 12 34 58

I have therefore sent a further query to my contacts in the Bible Societies.

DavidHaslam commented 6 years ago

@ThomHehl

The immediate requirement is to insert the space missing from the start tags \qt1.

I've just committed this global change in my branch, and will issue a PR shortly.

I also fixed a few tag errors in 1 Chronicles.

I also fixed the case for the main title in 1 Chronicles and Obadiah.