1) A reference to the issue addressed by this pull-request:
2) A description of the changes proposed in this PR:
3) Add @mentions for the people who will review this PR:
This PR is in response to issue #121 (see also issue #98).
Changes related to this issue have been rebased onto branch issue_117 for report production purposes, so this PR incorporates the commits on that branch as well. If PR #118 is merged into main in advance, this PR should become much "smaller".
This PR:
changes the output of calculate_stale_data() from a logical (TRUE/FALSE) to a string ("stale"/"fresh"). So it can be used directly in the Rmd as a CSS class name. The logical value wasn't being consumed elsewhere in the package as far as I can see
calculate_stale_data() is now vectorised and happens within the make bundle step instead of in the make report step (test expectations have been tweaked in response)
moves some ifelse logic from the Rmd details template into the make_bundle step
changes "last point" symbol for time between charts to a geom_annotate() step instead of a geom_point, as the use of geom_point() was generating a warning message on render.
bumps minor version number.
@ThomUK please review.
Please confirm that you have:
[x] Run devtools::test() and fixed all failing tests and warnings.
[x] Added suppressMessages() to any test message which breaks the test progress UI.
Please complete the following information:
1) A reference to the issue addressed by this pull-request:
2) A description of the changes proposed in this PR:
3) Add @mentions for the people who will review this PR:
This PR is in response to issue #121 (see also issue #98).
Changes related to this issue have been rebased onto branch
issue_117for report production purposes, so this PR incorporates the commits on that branch as well. If PR #118 is merged intomainin advance, this PR should become much "smaller".This PR:
calculate_stale_data()from a logical (TRUE/FALSE) to a string ("stale"/"fresh"). So it can be used directly in the Rmd as a CSS class name. The logical value wasn't being consumed elsewhere in the package as far as I can seecalculate_stale_data()is now vectorised and happens within the make bundle step instead of in the make report step (test expectations have been tweaked in response)geom_annotate()step instead of ageom_point, as the use of geom_point() was generating a warning message on render.@ThomUK please review.
Please confirm that you have:
devtools::test()and fixed all failing tests and warnings.suppressMessages()to any test message which breaks the test progress UI.