Rare-events, PDF output, File size reduction, Mobile friendly html report - Githubissues

ThomUK / SPCreporter

Creates Metric Reports using Statistical Process Control in the NHS style

https://thomuk.github.io/SPCreporter/

Other

6 stars 2 forks source link

Rare-events, PDF output, File size reduction, Mobile friendly html report #86

Closed ThomUK closed 11 months ago

ThomUK commented 11 months ago

Please complete the following information:

1) A reference to the issue addressed by this pull-request:
closes #82 closes #75 also does enabling work for #28, but does not complete it

2) A description of the changes proposed in this PR:

Adds rare event charts using raw event data
Add the ability to create pdf reports
Makes the html report mobile screen friendly
For detail of other changes see the NEWS file

3) Add @mentions for the people who will review this PR:
@francisbarton

Please confirm that you have:

[x] Run devtools::test() and fixed all failing tests and warnings.
[x] Added suppressMessages() to any test message which breaks the test progress UI.

Thank you for contributing to {SPCreporter}!!

francisbarton commented 11 months ago

It all looks really good to me Tom. I checked out the branch locally and looked through the main R files. I didn't look at the tests or the example data, but all the package checks pass. Tests generate a few warnings to do with using the variable reference style .data$var instead of .data[["var"]] in process_event_data_t. I could edit that file at a later date maybe.

Great to have got to this point and tidied up the various WIP branches into a single dev state that can be merged to main 🥂🍾 You've also resolved a few of the lingering questions about package design and what should live where.

Will also close my edits for #89 .