Thomas101 / react-native-fence-html

React Native component that renders HTML as native views
BSD 2-Clause "Simplified" License
177 stars 96 forks source link

Remove PropTypes check and warnings #15

Open fr1n63 opened 7 years ago

fr1n63 commented 7 years ago

Whenever you try and apply styles through html css - you're using propType functions directly which is throwing warnings that it will be removed in the next major version.

I understand why it's not feasible to use the standalone PropTypes package directly, as it isn't possible to infer the PropTypes functions from 'TextStylePropTypes' etc.

The original code would fail silently on invalid styles, I'm not entirely convinced that is the correct decision. So this basically removes the silent failure highlighting errors in styling, and removes the dependancy on PropTypes.

I've also bumped buffer to 5.0.0 - 4.9.1 was causing some errors with the Object.assign polyfill.

fr1n63 commented 7 years ago

Works for me...