Thomas55555 / husqvarna_automower

Custom component for Home Assistant to monitor and control your Husqvarna Automower
https://github.com/Thomas55555/husqvarna_automower
MIT License
105 stars 28 forks source link

remove depracated features #511

Closed Thomas55555 closed 1 year ago

Thomas55555 commented 1 year ago

Regarding blog: https://developers.home-assistant.io/blog/2023/07/10/vacuum-updates

prairiesnpr commented 1 year ago

Everything looks good, just not certain I understand the reason for removing the battery and status from the vacuum entity. Is there an upcoming depreciation in HA that I missed?

Current State:

Screenshot 2023-07-10 at 19 44 12

After Removal:

Screenshot 2023-07-10 at 19 43 49
Thomas55555 commented 1 year ago

There is a blog post... I've added it to the description. And the status attribute is not even documented anymore, although it works.

prairiesnpr commented 1 year ago

There is a blog post... I've added it to the description. And the status attribute is not even documented anymore, although it works.

Got it, not sure I understand the reasoning on HA removing them, but looks like that's where we are. I'm good, thanks.

prairiesnpr commented 1 year ago

We may want to consider retaining the status field as a separate sensor, if we find anyone used it.

Thomas55555 commented 1 year ago

I think some people use it indeed. But in the status is only information, which is already somewhere else. I don't think it's necessary to have redundant information.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 :warning:

Comparison is base (cfe2bcd) 99.00% compared to head (a714973) 98.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #511 +/- ## ========================================== - Coverage 99.00% 98.97% -0.03% ========================================== Files 16 16 Lines 1302 1270 -32 ========================================== - Hits 1289 1257 -32 Misses 13 13 ``` | [Impacted Files](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555) | Coverage Δ | | |---|---|---| | [custom\_components/husqvarna\_automower/const.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9jb25zdC5weQ==) | `100.00% <ø> (ø)` | | | [custom\_components/husqvarna\_automower/sensor.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9zZW5zb3IucHk=) | `100.00% <100.00%> (ø)` | | | [custom\_components/husqvarna\_automower/vacuum.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci92YWN1dW0ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thomas55555 commented 1 year ago

for error, see: https://github.com/home-assistant/developers.home-assistant/pull/1836

prairiesnpr commented 1 year ago

Do you mind if we merge #512 then rebase this PR? Especially since we have now removed the HusqvarnaAutomowerStateMixin.

Thomas55555 commented 1 year ago

Okay, I'm ready.

HenrikBachGravesen commented 1 year ago

A comment for the status field. I've got a switch, which operates 2 guide-wires for my automower. The switch switches between these 2 wires, which opens and closes a pathway from my back lawn to my front lawn. The path must be closed when the mower is actually mowing, and must be open when the mower is leaving og returning to the dock. There is an entity "Leaving dock" - if status is no longer available, could I please have an entity for "Returning to dock"?

Thomas55555 commented 1 year ago

Returning to dock is one of the states of the vacuum entity. You can use this. Next time please start a discussion or something like that and don't comment closes PR. It's hard to track stuff here.