Thomas55555 / husqvarna_automower

Custom component for Home Assistant to monitor and control your Husqvarna Automower
https://github.com/Thomas55555/husqvarna_automower
MIT License
105 stars 28 forks source link

fix Rest data do not arrive #518

Closed Thomas55555 closed 1 year ago

Thomas55555 commented 1 year ago

The Rest data don't arrive in the coordinator.

Thomas55555 commented 1 year ago

@prairiesnpr: I'm not getting into the tests. Last time as you fixed the tests it was a hundred of lines which were changed. So I couldn't understand it. Any idea, how to fix it. The current data isn't stored in coordinator.session.data anymore. It's no in coordinator.data. Should be a too big change in the tests?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.24 :warning:

Comparison is base (9a4f5e2) 98.98% compared to head (0d14b59) 98.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #518 +/- ## ========================================== - Coverage 98.98% 98.75% -0.24% ========================================== Files 16 16 Lines 1283 1283 ========================================== - Hits 1270 1267 -3 - Misses 13 16 +3 ``` | [Impacted Files](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555) | Coverage Δ | | |---|---|---| | [...om\_components/husqvarna\_automower/binary\_sensor.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9iaW5hcnlfc2Vuc29yLnB5) | `100.00% <ø> (ø)` | | | [custom\_components/husqvarna\_automower/calendar.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9jYWxlbmRhci5weQ==) | `100.00% <ø> (ø)` | | | [...stom\_components/husqvarna\_automower/diagnostics.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9kaWFnbm9zdGljcy5weQ==) | `100.00% <ø> (ø)` | | | [custom\_components/husqvarna\_automower/number.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9udW1iZXIucHk=) | `100.00% <ø> (ø)` | | | [custom\_components/husqvarna\_automower/select.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9zZWxlY3QucHk=) | `100.00% <ø> (ø)` | | | [custom\_components/husqvarna\_automower/\_\_init\_\_.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9fX2luaXRfXy5weQ==) | `97.19% <57.14%> (-2.81%)` | :arrow_down: | | [...m\_components/husqvarna\_automower/device\_tracker.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9kZXZpY2VfdHJhY2tlci5weQ==) | `100.00% <100.00%> (ø)` | | | [custom\_components/husqvarna\_automower/entity.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9lbnRpdHkucHk=) | `100.00% <100.00%> (ø)` | | | [custom\_components/husqvarna\_automower/image.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9pbWFnZS5weQ==) | `100.00% <100.00%> (ø)` | | | [custom\_components/husqvarna\_automower/sensor.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9zZW5zb3IucHk=) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/518?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

prairiesnpr commented 1 year ago

We lost some coverage in init, I'll look later this week at that, but this gets tests to pass again.

Thomas55555 commented 1 year ago

There are a lot of changes required. Probably I set this on hold and revert #518

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.