search

Thomas55555 / husqvarna_automower

Custom component for Home Assistant to monitor and control your Husqvarna Automower
https://github.com/Thomas55555/husqvarna_automower
MIT License
105 stars 28 forks source link

only update map on change #531

Closed Thomas55555 closed 1 year ago

Thomas55555 commented 1 year ago

Does this fix more or less aioautomower#78?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9296d5) 98.97% compared to head (dbc1d7c) 98.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ======================================= Coverage 98.97% 98.97% ======================================= Files 16 16 Lines 1267 1270 +3 ======================================= + Hits 1254 1257 +3 Misses 13 13 ``` | [Files Changed](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555) | Coverage Δ | | |---|---|---| | [custom\_components/husqvarna\_automower/image.py](https://app.codecov.io/gh/Thomas55555/husqvarna_automower/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas55555#diff-Y3VzdG9tX2NvbXBvbmVudHMvaHVzcXZhcm5hX2F1dG9tb3dlci9pbWFnZS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prairiesnpr commented 1 year ago

Sorry, saw the review request, but haven't been home long enough to review/test, I don't see any reason it won't work, but am curious if we even still see the dual report from aio automower. Wanted to verify that was still present and that this was even required.

Din-BH commented 1 year ago

Wonder if this will fix the issue in the new image sensor that makes it sometimes display an image without any mower movements, just current location. Or make it worse..

Thomas55555 commented 1 year ago

Sorry, saw the review request, but haven't been home long enough to review/test, I don't see any reason it won't work, but am curious if we even still see the dual report from aio automower. Wanted to verify that was still present and that this was even required.

That's okay. We can revert it if necessary.