Thomas89 / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

IE7 reports as IE6 #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Some installs of IE7 report themselves as being IE6. This results in the
simple modal appearing at the top of the screen. I have seen this problem
with ThickBox as well. I have reinstalled IE7 but it still has the issue.
One of my machines with IE7 works - the other one doesn't - both have the
same version number. When I alert from js "is this ie6" one install of IE7
returns "yes" and one returns "no"

What is the expected output? What do you see instead?
Expected = simple modal appears centered in the screen. The modal appears
near the top of the screen/off the top of the screen if the page has a
scrollbar.

What version of the product are you using? On what operating system?
v1.1.1, Windows XP, IE7 build 7.0.5730.13

Please provide any additional information below.

To patch the code file change the following (there may be a better way but
this was a combination, that I put together, of fixes from ThickBox
forums/blog posts that has the same problem that made the simple modal work
for me):

Drop this in:

$.browser.msie6 = 
        $.browser.msie 
        && /MSIE 6\.0/i.test(window.navigator.userAgent) 
        && !/MSIE 7\.0/i.test(window.navigator.userAgent)
        && (document.all && !window.opera && !window.XMLHttpRequest);

Then change:

>>// fix issues with IE and create an iframe
>>          if ($.browser.msie && ($.browser.version < 7)) {
>>              this.fixIE();
>>          }

to:

// fix issues with IE and create an iframe
            if ($.browser.msie6 && ($.browser.version < 7)) {
                this.fixIE();
            }

I have a very limited jquery knowledge so this may not be the best way but
I thought I'd post this here for others if they are having a problem with
IE7 not laying out correctly.

Original issue reported on code.google.com by jdst...@gmail.com on 26 Nov 2008 at 10:21

GoogleCodeExporter commented 8 years ago
This should be fixed in 1.2...let me know if it is still an issue.

Original comment by emartin24 on 4 Dec 2008 at 6:40