ThomasAlban / everforest-zed

🌲 Comfortable & Pleasant Color Scheme for Zed
14 stars 2 forks source link

title_bar.inactive_background is missing #2

Open patrickswijgman opened 2 months ago

patrickswijgman commented 2 months ago

It seems that the title_bar.inactive_background token for the theme is missing, resulting in a transparent title bar when inactive.

I'm running Linux (Ubuntu) and to fix it I had to add this to my settings:

  "experimental.theme_overrides": {
    "title_bar.inactive_background": "#1b2024"
  },

I really love this theme so thanks a lot for the port! Cheers!

ThomasAlban commented 2 months ago

Ok brilliant, if you want you can submit a pr and I'll merge it in, or I can just do it myself!

patrickswijgman commented 2 months ago

I found an issue reported to the Zed repo here: https://github.com/zed-industries/zed/issues/14955 and they reference this issue: https://github.com/zed-industries/zed/pull/15709 which is supposed to be in version 148 but it still doesn't work for me :thinking: so just to be safe I can create a PR! :raised_hands:

patrickswijgman commented 2 months ago

I tried to make a branch and push but I am not allowed to :(

This is my diff:

diff --git a/themes/everforest-dark.json b/themes/everforest-dark.json
index e151ff2..50a1222 100644
--- a/themes/everforest-dark.json
+++ b/themes/everforest-dark.json
@@ -39,6 +39,7 @@
         "icon.accent": null,
         "status_bar.background": "#21272b",
         "title_bar.background": "#21272b",
+        "title_bar.inactive_background": "#1b2024",
         "toolbar.background": "#272e33",
         "tab_bar.background": "#21272b",
         "tab.inactive_background": "#21272b",
ThomasAlban commented 2 months ago

@patrickswijgman do I need to change a setting in GitHub or something to allow pull requests? Or is it a problem on your end? You should be able to fork this repository, make the change, then submit a PR by clicking contribute on the GitHub page of your forked repository