search

ThomasHabets / arping

ARP Ping
http://www.habets.pp.se/synscan/programs.php
GNU General Public License v2.0
398 stars 62 forks source link

Avoid relying on implicitly-defined setgroups #42

Closed susnux closed 3 years ago

susnux commented 3 years ago

Fix potential build errors.

This patch is from the openSUSE project (still used there).

ThomasHabets commented 3 years ago

Thanks!

ThomasHabets commented 3 years ago

Hang on, this isn't right. grp.h is already included. I'm backing this out.

ThomasHabets commented 3 years ago

I went in to clean up and make sure autoconf looked for grp.h and conditionally include it, just like the logic for the the other header files. Turns out it already was.

What makes you say this PR was needed?

susnux commented 3 years ago

Oh sorry, seems to be unneeded now. This patch is used for quite a long time, tested the build success with the latest release (which is fine), but did not noticed it is fixed already without this patch.

ThomasHabets commented 3 years ago

Ah, alright. Are you the maintainer at opensuse that would be the one to remove it from there, or should I leave a comment here, or somewhere?

For reference this was fixed back in arping-2.16 (2015).

Thanks for working to upstream fixes. It wasn't needed this time, but it's valuable work!

susnux commented 3 years ago

Are you the maintainer at opensuse that would be the one to remove it from there, or should I leave a comment here, or somewhere?

No I am not, but I already filed a submit request, for dropping that patch and updating the package: https://build.opensuse.org/request/show/905353

Thanks for working to upstream fixes. It wasn't needed this time, but it's valuable work!

I often see quite old patches not upstreamed (but still needed), so I decided to report them upstream, this time my testing was insufficient :/