search

ThomasHabets / arping

ARP Ping
http://www.habets.pp.se/synscan/programs.php
GNU General Public License v2.0
398 stars 62 forks source link

configure.ac: make --disable-seccomp work #51

Closed thesamesam closed 2 years ago

thesamesam commented 2 years ago

The first branch ("[action-if-given]") is taken even if --disable-seccomp is passed. So, in that branch, check whether the user disabled it or not.

Without this, we'd get a failure when seccomp is detected but we want to disable it:

./configure --disable-seccomp
[...]
checking for library containing clock_gettime... none required
configure: error: --enable-seccomp given but seccomp libraries not present

Signed-off-by: Sam James sam@gentoo.org

ThomasHabets commented 2 years ago

Ugh, well that's surprising to me. But perfectly documented.

This also means that if seccomp libraries are present and configure is given --disable-seccomp, it'll both be enabled and defaulted to on (DEFAULT_SECCOMP).

Do you want to fix that, or should I merge this and do that party myself?

ThomasHabets commented 2 years ago

Fixed in https://github.com/ThomasHabets/arping/commit/9da03da63b7e793caa98488c67993ad4cd08188f