ThomasHabets / cmdg

Command line Gmail client
Other
201 stars 22 forks source link

Fix: `view_openmessage` "q" quits openmessage instead of everything #77

Closed TheJoeSchr closed 3 years ago

TheJoeSchr commented 3 years ago

Hi,

a minor fix, but a big annoyance fix, at leas from my perspepective. I'm pretty used from vim that "q" acts as quit buffer and so I automatically press it. But cmdg would quit overall.

Not sure if this is for general population or where you want to go with hotkeys (you are an emacs user right?). put I thought I would at least try to share it.

ThomasHabets commented 3 years ago

cmdg doesn't yet have a config system, but this seems like something that should be configurable.

I won't merge this, though, since I made q quit directly on purpose. It's a matter of taste, and unfortunately my preference is that it quits from this view.

TheJoeSchr commented 3 years ago

Fair enough!

__

Typed on a mobile, please excuse any typing mistakes or short-spokeness.

On Mon, 8 Feb 2021, 19:31 Thomas Habets, notifications@github.com wrote:

cmdg doesn't yet have a config system, but this seems like something that should be configurable.

I won't merge this, though, since I made q quit directly on purpose. It's a matter of taste, and unfortunately my preference is that it quits from this view.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ThomasHabets/cmdg/pull/77#issuecomment-775351950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6WSHTRVY5CKDTBRURU3WLS6AUWHANCNFSM4XIYZFIA .