ThomasHoooo / pe

0 stars 0 forks source link

Entering an extreme low cap doesn't reflect properly in UI and may cause confusion #5

Open ThomasHoooo opened 1 year ago

ThomasHoooo commented 1 year ago

I am allowed to parse in 0.00000001 as my cap. However the UI shows that the cap is 0.00. It is confusing to the user because the cap seems to be 0 but it is not.

steps to reproduce: add n/John Doe p/98765432 e/joh2nd@example.com a/311, Clementi Ave 2, #02-25 c/0.00000001/4.00 g/male u/Nanyang Polytechnic gd/05-2024 m/Computer Science ji/173296 jt/Software Engineer Intern t/rejected

soc-pe-bot commented 1 year ago

Team's Response

It is already mentioned in the UG that cap values will be rounded to two decimal places.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[x] I disagree

Reason for disagreement: Since it is rounded, therefore there will be a bug as the user guide stated that CURRENT_CAP must be a positive value, but a value of 0 can be passed in.