search

ThomasJockin / readexpro

Readex Pro is the world-script expansion of Lexend. Lexend is a variable font empirically shown to significantly improve reading-proficiency.
http://www.lexend.com
SIL Open Font License 1.1
505 stars 24 forks source link

[website] Fix working for real #8

Closed davelab6 closed 5 years ago

davelab6 commented 5 years ago

My first PR (https://github.com/ThomasJockin/lexend/pull/2/files) fixed the wording in the website branch (so that that subsequent yarn deploy runs would not overwrite the next PR)

My second PR (https://github.com/ThomasJockin/lexend/pull/4/files) fixed the HTML files in the gh-pages branch directly (and I just fixed the mistaken title of the PR) but somehow the changes are not showing up... :(

I don't believe a 3rd PR is needed, but I don't understand why my fixed haven't shipped yet. I need them shipped urgently :)

ThomasJockin commented 5 years ago

Let me circle back with @micahbrich on Wednesday on how to proceed.

micahbrich commented 5 years ago

Oh, @davelab6 — I'm 99% sure Github only triggers a rebuild & redeploy when there's specifically a push to the website branch (which is what that yarn deploy command does).

Which means I'm pretty positive even if you do a PR on the website branch with changes, you still have to pull down the changes locally & run yarn deploy to see it in production. I updated the readme last week or so outlining the process, if that helps.

GH pages is pretty manual — as far as I know, the only way around doing all that merging & deploying locally, while keeping it hosted on GH Pages, is setting up a continuous integration/deployment tool to watch for changes and do all that for you in the cloud. Seems peeps use Travis CI or similar for that, I suspect the GH Actions beta will probably be able to do that. But that's probably all overkill for something that probably won't get updated much — I'd suggest just pulling changes locally & running yarn deploy manually.

micahbrich commented 5 years ago

P.S. I'm proud of how much I used the word "probably":

Screen Shot 2019-07-02 at 1 39 14 PM
micahbrich commented 5 years ago

Alright, @davelab6, I just pulled down the changes in website and typed yarn deploy for you, you should see them live now.

In the future, that should be all you have to do if you have to update anything — don't worry about touching the gh-pages branch, just make changes to website and yarn deploy locally. 👌