search

ThomasKaiser / sbc-bench

Simple benchmark for single board computers
BSD 3-Clause "New" or "Revised" License
627 stars 78 forks source link

Missing packages for -T option #74

Closed dominch closed 11 months ago

dominch commented 11 months ago

Just tried -T option to test some notifications and cpu frequencies on current version and I found out that its not checking requirements. It was done on plain rpi 4b, -T option gives me message about temporary github problem while installing mhz. Inspecting code shows that it just tries to clone that from git and it was easy to find that git is missing on this system. I added it via apt-get and then there was warning about missing iostat (line 3049), so I needed to add sysstat package. After those everything worked correctly, sbc-bench installed something more but no warnings/errors.

As far as I remember on other command line switches it adds needed tools, maybe here one another check is needed for those two packages or bins.

ThomasKaiser commented 11 months ago

Thanks for pointing this out. I chose a quick&dirty fix and just call the InstallPrerequisits function that might install a few more packages that are not really needed in this mode. But since this is usually only dmidecode and lm-sensors with a combined installed size of half a MB I'm fine with this.

dominch commented 11 months ago

That should be ok, probably most users will use more than this mode, so they will trigger this function eventually :) Thanks for this and You time :)