Feedback from Tomasz - Githubissues

ThomasKronhol / Macro

Research rapport

MIT License

1 stars 3 forks source link

Closed donotdespair closed 1 year ago

donotdespair commented 1 year ago

Hi @ThomasKronhol

This is a very good submission! Thank you! It's very informative! WOW!

I would just ask. you to

[x] include ADF test results for diff to determine the integration order of all variables as in the example in ba4d69ffd3774ca52d4526ab5ffc5bf6151cb741

Good luck!

donotdespair commented 1 year ago

Hi @ThomasKronhol

Hey, it's OK to reject the pull request. Would you please comment on what you have done with the proposed changes in a note in this PR? Thanks.

ThomasKronhol commented 1 year ago

Hi @donotdespair

Thanks for your feedback!

I have implemented all suggested changes, but I was worried that it would change my newest file, and chose therefore not to merge!

Thanks

Thomas