search

ThomasKronhol / Macro

Research rapport
MIT License
1 stars 3 forks source link

Pull request #4

Closed Eung1 closed 1 year ago

Eung1 commented 1 year ago

Hi @ThomasKronhol

Well done. I should say that your work is a good example that I have been referring to for my work. Code is well organized so I don't see any part to be improved further. Comparing the baseline model and the extended model gives a sense of how the hyperparameters are estimated for the extended model. And the most of the results make economics sense.

Here are some suggestions on your work.

  1. More explicit hypotheses would nicely attract readers since it helps them maintain focus and provides guidance throughout the reading.

  2. I think it would be better if some reasons are provided for the selection of hyper-parameter (kappa1=0.1, kappa2 = 10, kappa0 = 10) for the baseline model, if any.

Good luck for the rest of your project!

ThomasKronhol commented 1 year ago

Hi @Eung1

Thank you very much for your comments!

I believe you are correct regarding the hypothesis as well as the hyper parameters! I'll have a look!