search

ThomasLecocq / SeismoRMS

A simple Jupyter Notebook example for getting the RMS of a seismic signal (from PSDs)
European Union Public License 1.1
86 stars 38 forks source link

A few fixes #6

Closed claudiodsf closed 4 years ago

claudiodsf commented 4 years ago

Also, to reduce the diffs, I think it's better to commit the notebooks after having cleared them. We can think at adding a rendered version, saved as HTML to show the results. What do you think?

ThomasLecocq commented 4 years ago

agree on all :) the diffs are getting crazy here :)

FMassin commented 4 years ago

This is overwriting a lot of my addons, could you merge with last version?

Please note that I've added a parameter dataset which is quite useful to specify a path where to store data or avoid conflict between multiple similar copies of the notebook...

claudiodsf commented 4 years ago

Oops, sorry, I didn't noticed that you already fixed some of these things.

I'll solve the conflicts and rebase 😉

FMassin commented 4 years ago

Oops, sorry, I didn't noticed that you already fixed some of these things.

I'll solve the conflicts and rebase 😉

OK, see above and #5.

claudiodsf commented 4 years ago

Ok, done!

FMassin commented 4 years ago
  • ~Use traceid in file names, so that it is possible to rerun the notebook for a different stream~

I did not meant to get rid of this, I like it, and it is not conflicting at all :), I would keep it.

Also, to reduce the diffs, I think it's better to commit the notebooks after having cleared them. We can think at adding a rendered version, saved as HTML to show the results. What do you think?

Yes, I think you can do this within a single cell added at the end of the notebook:

%autosave 1
import time
time.sleep(2)
%autosave 120
!jupyter nbconvert --to html SeismoSocialDistancing.ipynb
!nbstripout SeismoSocialDistancing.ipynb

It looks awful but it works as long as the file is not renamed.

claudiodsf commented 4 years ago

I did not meant to get rid of this, I like it, and it is not conflicting at all :), I would keep it.

Ok, see my last commit.

claudiodsf commented 4 years ago

Yes, I think you can do this within a single cell added at the end of the notebook:

I'll look into that tomorrow 🥱

megies commented 4 years ago

agree on all :) the diffs are getting crazy here :)

One of the downsides of Jupyter notebooks, not good for version control. Has been one of the main issues for seismo-live all the time, that's why we recently switched to keeping notebooks as jupytext in the version control and build notebooks just for the final page from these. See krischer/seismo_live#33

claudiodsf commented 4 years ago

@ThomasLecocq Can we merge this? I'll look into remaining issues in a different PR.

ThomasLecocq commented 4 years ago

sure ! don't make the whole calculation stuff tooooooo crazy, msnoise2.0 (actually in master later today) has the QC/PPSD computation built in, all that will be required will be