Open dylanmikesell opened 4 years ago
ThomasLecocq
commented
4 years ago @dylanmikesell thanks a bunch for all this. Haven't had time to check it yet, but will do in the coming days. Without having looked at the code, just a remark: be carefull when converting lat/lon to UTM using pyproj, if a network is across two UTM zones, we need to fix one, otherwise the distances will be crazy large.
Will be updated in the coming days, maybe we could chat/video with Aurel ? Cheers
dylanmikesell
commented
4 years ago Yes. Video chat would be good. Just fixed the two UTM zone problem in my fork. Can do a PR but would like to chat with you and Aurelien first to make sure you like the way I did it.
On Mon, Oct 26, 2020, 12:08 PM Thomas Lecocq notifications@github.com wrote:
@dylanmikesell https://github.com/dylanmikesell thanks a bunch for all this. Haven't had time to check it yet, but will do in the coming days. Without having looked at the code, just a remark: be carefull when converting lat/lon to UTM using pyproj, if a network is across two UTM zones, we need to fix one, otherwise the distances will be crazy large.
Will be updated in the coming days, maybe we could chat/video with Aurel ? Cheers
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ThomasLecocq/msnoise-tomo/pull/23#issuecomment-716729832, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVIE4UT6F66ZPIB4NRWROLSMW3I7ANCNFSM4S534FHQ .
ThomasLecocq
commented
3 years ago again, let me know if you feel it's OK and I'll merge :)
dylanmikesell
commented
3 years ago Sorry, will get back to you next week. I need to refresh my brain about this.
On Wed, May 12, 2021 at 10:28 AM Thomas Lecocq @.***> wrote:
again, let me know if you feel it's OK and I'll merge :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ThomasLecocq/msnoise-tomo/pull/23#issuecomment-839920907, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVIE4UGMZV67WOFUOLYQVLTNKUD7ANCNFSM4S534FHQ .
I refactored this code considerably. Many things were moved to functions, including all plot types. Also moved to a grid in kilometers rather than degrees. There is a verbose flag in the code (not accessible from CLI yet) that will turn on logging/debugging output to see the dimensions of various parameters/matrices. There is also a plot flag for either UTM or local. Local shows plots in a local grid relative to mean station location. This is not a CLI input yet either. Have to change source code. I took all of the UTM conversion from https://gist.github.com/twpayne/4409500. I include the "unproject()" function so we can go back to lat/lon for plotting. But this is not currently implemented.