Fix: Dialog PluginOptions defaults taking precedence over component dialogOptions

ThomasLeconte / vuetify3-dialog

Vue 3 & Vuetify 3 plugin to create dialogs (confirm, warn, error), toasts or bottom-sheets with Promises anwsers.

https://www.npmjs.com/package/vuetify3-dialog

MIT License

26 stars 9 forks source link

Closed Shaxine closed 6 months ago

Shaxine commented 6 months ago

Previous to this fix, using defaults.dialog.component:

app.use(Vuetify3Dialog, {
  vuetify: vuetifyInstance,
  defaults: {
    dialog: {
      component: { width: 'auto' },
    },
  }
})

Would take precedence over dialogOptions:

createDialog({
  customComponent: {
    component: MyCustomComponent,
  },
  dialogOptions: {
    width: "600px",
    persistent: true
  }
})

ThomasLeconte commented 6 months ago

Hi, thanks for PR. I will prevent you when release will be published !

ThomasLeconte commented 5 months ago

Hi! New version 1.4.8 includes your fix !