search

ThomasLeconte / vuetify3-dialog

Vue 3 & Vuetify 3 plugin to create dialogs (confirm, warn, error), toasts or bottom-sheets with Promises anwsers.
https://www.npmjs.com/package/vuetify3-dialog
MIT License
26 stars 9 forks source link

Closing custom dialog has no animation #7

Closed Joebayld closed 11 months ago

Joebayld commented 11 months ago

I made a dialog with a custom component, but when I call $emit("closeDialog") it closes the dialog immediately and doesn't do the fade animation. I think the issue is happening here: 

resolve(value);
_app.unmount();
document.body.removeChild(div);

Perhaps it needs some sort of delay before removing from the document dom?

ThomasLeconte commented 11 months ago

Hey ! Thanks for report, it has been fixed in my last version 1.4.2 😉 More details in this commit