Msvc fixes - Githubissues

ThomasMonkman / filewatch

File watcher in c++

MIT License

426 stars 70 forks source link

Closed pezcode closed 3 years ago

pezcode commented 4 years ago

I fixed a few issues that appeared with Visual Studio 2019. Tested with g++ 7.4.0 and clang 6.0.0. Untested with earlier versions of Visual Studio.

removed the whole dependency on UNICODE/_UNICODE. always uses the underlying char type now
std::filesystem::path has no rbegin/rend. iterating over a path gives you parts of the path (directories, file name, etc.) and not characters, anyway
added a missing iostream header

pezcode commented 4 years ago

ThomasMonkman commented 4 years ago

Great work, thank you for the PR!

I'll take a look when I find the time. Yes that Unicode part was always a pain

ThomasMonkman commented 3 years ago

Sorry I took so long to get around to this pr, thank you very much for! really nice work.