search

ThomasRipplinger / 14ColmarAcademy

Capstone project - landing page
0 stars 0 forks source link

Line breaks in HTML #2

Closed jordanwillis closed 6 years ago

jordanwillis commented 6 years ago

As I was reviewing your code I stumbled upon a few instances of line break usage (<br/>).

https://github.com/ThomasRipplinger/14ColmarAcademy/blob/master/index.html#L39 https://github.com/ThomasRipplinger/14ColmarAcademy/blob/master/index.html#L41 https://github.com/ThomasRipplinger/14ColmarAcademy/blob/master/index.html#L51

While it is often convent to use line breaks to quickly fix spacing, sizing, or alignment issues, I would recommend that you shy away from using line breaks and handle this sort of thing directly in your CSS. As you will continue learning and practicing in BWS, we want our HTML to be as semantic as possible and line breaks takes away from that.

Some things that you can do instead is of using
` is add extra margin or padding properties to your CSS or tweaking some of your flexbox related properties.

ThomasRipplinger commented 6 years ago

ok, understood, I've fixed it