search

ThomasToka / MarlinFirmware

This is [MARLIN-E3S1PROFORK-BYTT]. A Fork of Marlin 2.1.x-bugfix with the Creality Ender 3 S1 Pro source code included. Personal tweaks, fixes and enhancements included. This firmware is for the Ender 3 S1 Pro (touchscreen) and Ender 3 S1 Plus (touchscreen).
231 stars 8 forks source link

Print doesn't "finish" #55

Closed lin-ycv closed 9 months ago

lin-ycv commented 9 months ago

On v25, when a print is finished, the still shows the pause and stop buttons instead of finish, causing each print to be logged as a cancelled print.

lin-ycv commented 9 months ago

Also it's possible to set 1 as y margin, which causes crashes.

ThomasToka commented 9 months ago

The first i could reproduce. Will have a look later where the breaking change was.

But the second: You probably had a display glitch. Then the display beeps takes the value, shows it, but does not transmit it to the mainboard. Cause if it would transmit it to the mainboard the mainboard firmware bounced when entering a value lower 10 the min possible value of 10 back. The second part did not happen here. so you have seen the 1 on the display but the margin in the mainboard firmware wasnt changed. Here i can´t do nothing as in this moment nothing is transferred to the mainboard so i cant make any actions. Please reenter 1 -> it should be bounced to 10. If not do it again.

lin-ycv commented 9 months ago

For setting the margin, I typed in 0, and it's would show up as 1, after that I ran a bed level, and it crashed. I'm using the zero y offset mod.

ThomasToka commented 9 months ago

Show me a pic of your:

probe offsets site home offsets site leveling site with the margins

ThomasToka commented 9 months ago

I have just uploaded the hotfixed binarys to address the finishing site bug.

The second i could not reproduce. So i need more data like requested earlier today.

lin-ycv commented 9 months ago

Flashed back to v24 yesterday and did a printed, it just finished. I've now flashed back to v25 using the updated file, and the second issue of safety margin still exist. 20240126_185323 20240126_185344 20240126_185458 In this video you see how close it is to the edge, my home offset is off, so when levelling the rear points it probes outside the bed https://github.com/ThomasToka/MarlinFirmware/assets/60565737/db0fceff-be4a-4f2a-b4c1-294837ae6a27

ThomasToka commented 9 months ago

please show me additionally the about site of your printer.

lin-ycv commented 9 months ago

20240126_195005

ThomasToka commented 9 months ago

cant reproduce this. :( thats what i do:

how you do it exactly?

lin-ycv commented 9 months ago
ThomasToka commented 9 months ago

ok great now i could reproduce it.

set 1 to y and it will reaccount.

setting 0 does not reaccount in this constellation.

i will fix this also, but dont know if a hotfix or in the next version.

ThomasToka commented 9 months ago

i have just pushed the hotfix for the 0 y issue:

https://github.com/ThomasToka/MarlinFirmware/releases/tag/MARLIN-E3S1PROFORK-BYTT-v025