search

ThomasVitale / cloud-native-spring-in-action

🍃 Code samples and projects from the book "Cloud Native Spring in Action - With Spring Boot and Kubernetes" (Manning)
https://www.manning.com/books/cloud-native-spring-in-action
Apache License 2.0
426 stars 257 forks source link

Incorrect initialize Greeting Service #5

Closed archisova closed 3 years ago

archisova commented 3 years ago

Hi, Thomas Vitale!

I noticed that when initializing the Greeting Service project from Chapter 02 - Begin, the link to spring.io starter is incorrectly specified. In your case, the link is https://start.spring.io/starter.tgz (!.tgz), with the key -o greeting-service.zip (!.zip) and when downloading the project, the archive turns out to be broken. I will offer two solutions:

  1. You can leave the tgz, but then the -o greeting-service.zip parameter must be removed and added at the end of | tar -xzvf -. For example for Gradle: curl https://start.spring.io/starter.tgz -d groupId=com.arcticgreetings -d artifactId=greeting-service -d name=greeting-service -d packageName=com.arcticgreetings.greetingservice -d dependencies=web -d javaVersion=16 -d bootVersion=2.5.2 -d type=gradle-project | tar -xzvf -

  2. You can change the starter link by specifying it https://start.spring.io/starter.zip For example for Gardle: curl https://start.spring.io/starter.zip -d groupId=com.arcticgreetings -d artifactId=greeting-service -d name=greeting-service -d packageName=com.arcticgreetings.greetingservice -d dependencies=web -d javaVersion=16 -d bootVersion=2.5.2 -d type=gradle-project -o greeting-service.zip

ThomasVitale commented 3 years ago

@archisova thanks for reporting the issue. I fixed it and merged it in https://github.com/ThomasVitale/cloud-native-spring-in-action/pull/6