ThomasVon2021 / blikvm

Open and cost-effective "KVM-over-IP". BliKVM comes in 4 different models, v1 CM4, v2 PCIe, v3 HAT and v4 Allwinner, based on Raspberry Pi and Allwinner SoC.
https://thomasvon2021.github.io/blikvm/
GNU General Public License v3.0
360 stars 31 forks source link

Include copyright notice for third-party code #3

Open mtlynch opened 1 year ago

mtlynch commented 1 year ago

./package/kvmd-hid/enable-gadget.sh seems to be derived from TinyPilot's copyrighted code here:

https://github.com/tiny-pilot/ansible-role-tinypilot/blob/master/files/init-usb-gadget

./package/kvmd-hid/disable_gadget.sh seems to be derived from TinyPilot's copyrighted code here:

https://github.com/tiny-pilot/ansible-role-tinypilot/blob/master/files/remove-usb-gadget

TinyPilot's code is released under the MIT license, so you're welcome to include it, but the license requires preserving the copyright notice and license.

You can get back into compliance with the license this by copying the text from TinyPilot's license as a header at the top of each derived file or by including TinyPilot's license in a file called NOTICE at the root of the repo.

ThomasVon2021 commented 1 year ago

https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/disable_gadget.sh https://github.com/ThomasVon2021/blikvm/blob/master/package/kvmd-hid/enable-gadget.sh Thank you for reminding me. It's correct.

mtlynch commented 1 year ago

Thanks!

mtlynch commented 6 months ago

@ThomasVon2021 - The license notice was removed in https://github.com/ThomasVon2021/blikvm/commit/74b7bd0d8df57922b05f207716411421b16dcc67#diff-13cf57767c8d201ac67a5de3c2f07904a3b64bb3e48075446c10c31f14f68c77

You're required to either remove the file or preserve the license.

ThomasVon2021 commented 6 months ago

https://github.com/ThomasVon2021/blikvm/commit/0deef067b4d728074f35037841a0f2b41acabb66 Thank you for your remind.

ThomasVon2021 commented 6 months ago

I have a question to ask you. I use GPL-3.0 license for other code, should I also add this description to all my original code?

mtlynch commented 6 months ago

It varies by project. Some choose to include the notice on every file, and others choose a single license file at the root. See:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#determining-the-location-of-your-license