ThomasVon2021 / blikvm

Open and cost-effective "KVM-over-IP". BliKVM comes in 4 different models, v1 CM4, v2 PCIe, v3 HAT and v4 Allwinner, based on Raspberry Pi and Allwinner SoC.
https://thomasvon2021.github.io/blikvm/
GNU General Public License v3.0
355 stars 30 forks source link

[Bug] dev installation instructions fatal error: janus/plugins/plugin.h: No such file or directory #6

Open magore opened 1 year ago

magore commented 1 year ago

https://github.com/ThomasVon2021/blikvm/blob/master/dev-readme.md ustreamer build fails looking for #include <janus/plugins/plugin.h>

Perhaps you wanted to look in janus-gateway/src/plugins/plugin.h There is no janus/plugins/plugin.h directory

ThomasVon2021 commented 1 year ago

Have you install janus before?

magore commented 1 year ago

No, I have not built janus from source prior to your build dev-readme.md instructions for ustreamer. Although, external to your notes, I was aware that janus was also an available package from apt I chose the source route as you docmented it to be safe gven there were no other notes in your document. Note: Janus itself compiled fine as you documented it. However ustreamer failed if we includeded your ustreamer build option WITH_JANUS=1 - without that it builds - not sure what that breaks.

ThomasVon2021 commented 1 year ago

You should build janus before. According to instructions to config janus.

magore commented 1 year ago

Janis was built before ustreamer following instructions exactly ias outlined in your dev-readme.md I would suggest you build everything in a clean environment and update your dev-readme.md so they work correctly.

ThomasVon2021 commented 1 year ago

I had builded in a clean environment.

magore commented 1 year ago

As I said before there is no janus/plugins/plugin.h file just the janus-gateway/src/plugins/plugin.h. All of the other KVM projects edit the file to correct the path. This step is missing in your dev-readme.md instructions.

See for example of this being fixed: https://github.com/tiny-pilot/ansible-role-ustreamer/blob/master/tasks/install_janus.yml

freeyoung commented 1 year ago

I encountered the same issue. Had to follow the official docs to mitigate the compiling errors of make WITH_JANUS=1:

ln -s /opt/janus/include/janus /usr/include/janus

and

sed \
  --in-place \
  --expression 's|^#include "refcount.h"$|#include "../refcount.h"|g' \
  /usr/include/janus/plugins/plugin.h
ThomasVon2021 commented 1 year ago

As I said before there is no janus/plugins/plugin.h file just the janus-gateway/src/plugins/plugin.h. All of the other KVM projects edit the file to correct the path. This step is missing in your dev-readme.md instructions.

See for example of this being fixed: https://github.com/tiny-pilot/ansible-role-ustreamer/blob/master/tasks/install_janus.yml

According to freeyoung comment, have you solved your problem?

ThomasVon2021 commented 1 year ago

https://wiki.blicube.com/blikvm/en/flashing_os/ Hi, I have share the image which can run all of software OK. You can test base on this image.

m50S79sM6SRNp8Jn commented 5 months ago

Can this issue be closed?