ThomazPom / Moz-Ext-UltimaDark

A web extension that uses aggressive techniques to enable dark mode on every site.
127 stars 6 forks source link

Support local files and protected pages #105

Open mkoushan opened 1 month ago

mkoushan commented 1 month ago

Sorry for creating a new issue, but I thought this won't require much effort and is quite different with enhancements listed in mentioned issue.

Simply the extension works great in darkening websites, even protected pages which come from the network. But for some reasons it won't make local pages dark. I think the streamline is different from the web content or something, I'm not sure. Thanks!

Vintagemotors commented 1 month ago

I assumed this worked with permissions allowed but you are correct that it does not (by default at least) as it is blocked by Firefox's security policy. You can try changing extensions.quarantinedDomains.enabled to false in about:config (made no difference in my testing) but I see people have the same issue with other extensions so it's not unique to UltimaDark. I do not see an appropriate permission available to correct this either (unless the "storage" permission grants access to the user's entire file system and not just the folder allocated by Firefox for the extension to use). docs

mkoushan commented 1 month ago

I assumed this worked with permissions allowed but you are correct that it does not (by default at least) as it is blocked by Firefox's security policy. You can try changing extensions.quarantinedDomains.enabled to false in about:config (made no difference in my testing) but I see people have the same issue with other extensions so it's not unique to UltimaDark. I do not see an appropriate permission available to correct this either (unless the "storage" permission grants access to the user's entire file system and not just the folder allocated by Firefox for the extension to use). docs

I have that settings disabled from Dark Reader extension. That time it had darken my local html files (I've downloaded cpp reference). Dark Reader makes it dark because it changes the css after the page gets loaded. But in Ultima you change it in the streamline before getting to gecko and I think that's why it don't work with local file. I guess the streamline with local html files are different, if I get time I'll look into it currently I'm really busy doing life.

mkoushan commented 1 month ago

With or Without Ultima: image

With Dark Reader: image