search

ThomazPom / Moz-Ext-UltimaDark

Web Extension that uses agressive technique to get dark mode everywhere
34 stars 3 forks source link

Question about "i.reddit.com" whitelisted (Priority Level: Low) #22

Closed EstherMoellman closed 4 years ago

EstherMoellman commented 4 years ago

I use "https://i.reddit.com/" all the time. But I have my own CSS reddit' customized dark theme (which also blocks some reddit' garbage). So I tried to whitelist "https://i.reddit.com/" at UltimaDark.

When I select precision of 3 letters, it appears: ://i.reddit.com/ ://.i.reddit.com/ ://www.redditstatic.com/ ://.www.redditstatic.com/

If I don't include "redditstatic" then UltimaDark doesn't whitelist "i.reddit.com". The problem is that whitelisting "redditstatic" also whitelists "old.reddit.com"... and I don't want "old.reddit.com" whitelisted.

So, my question is: Am I doing something wrong? Or is this a UltimaDark' whitelist bug?

Thks! : )

ThomazPom commented 4 years ago

i.reddit fetchs its styles from redditstatic.com. This is why if you don't exclude redditstatic, the redditstatics styles gets edited and the website ends dark This is so far the normal behaviour.

This can cause problem if you wand to use i.reddit.com in white and www.reddit.com in black as they both use redditstatic.

To fix : I could detect when a blacklisted website(i.redit there) loads a style on another domain (like redditstatic.com) and ignore it The blacklist would be shorter, because you wolud not have to deal with Content Delivery Networks domains as redstatic.

ThomazPom commented 4 years ago

This is fixed in the next version of ultimadark

ThomazPom commented 4 years ago

It makes a shorter blacklist to check, better performance

ThomazPom commented 4 years ago

And it makes more sense for user

ThomazPom commented 4 years ago

1.1.6 is availble and includes this edit