search

ThomazPom / Moz-Ext-UltimaDark

Web Extension that uses agressive technique to get dark mode everywhere
34 stars 3 forks source link

V.1.2.3 conflicts with Temporary Container add-ons (any) (Priority level: High) #28

Closed EstherMoellman closed 8 months ago

ThomazPom commented 4 years ago

May this be only your cache ?

EstherMoellman commented 4 years ago

Hi @ThomazPom !

It took me time, but I found the culprit: Is a conflict between UltimaDark V1.2.3 and Temporary Container add-ons (any).

Way to reproduce:

Result: In order to load, every new tab needs "enter" to be pressed (at least) twice.

Disable UltimaDark V1.2.3 and everything works fine. Or keep Ultima enabled and disabled Temporary Container add-on, and everything works fine.

EstherMoellman commented 4 years ago

V1.2.8 is has an improvement in this issue. Now all tabs are opened pressing "enter" one time. However and unfortunately, if UltimaDark is enabled with a Container add-on, then lot of pages are broken, or aren't darkened.

EstherMoellman commented 4 years ago

I opened an issue: https://github.com/sagitta1618/tabContainer/issues/8

EstherMoellman commented 4 years ago

Curious event worth mentioning: Latest versions of UltimaDark were consuming around (±) 2.3MB of RAM. V1.2.9 was the highest, with (±) 3MB. However, when containers are enabled, V1.2.9 RAM consumption drops to (±) 2MB. Unfortunately the UltimaDark and Containers conflict still exists, and if both are enabled then pages are broken or not darkened. But the drop in RAM consumption seems interesting, and I hope in the future might be useful to improve UltimaDark' RAM.

PS: It's not really the RAM consumption that matters. If UltimaDark consumes 1000GB RAM, and this makes UltimaDark better and faster, then I don't care!, RAM is there to be consumed, is fine to consume RAM. The problem is that RAM consumption in some cases is also associated to CPU use... and this is the problem... because CPU interferes with browser performance, kills battery, generates hit etc etc etc.

ThomazPom commented 3 years ago

Hey In previous versions, UltimaDark was blocking any addon request for technical reasons (It was atempting to block its own unwanted side loads) . This issue may be fixed.

Thank you again for your work.

ThomazPom commented 3 years ago

About the ram, UD uses the ram to lower cpu usage, as once the darkening of a color is pre calculated, the cpu wont have to do it again. There is still a LOT of possible optimization but i'm working on nice aestetics first, because optimization is (for me) the easy part

EstherMoellman commented 3 years ago

Hi @ThomazPom ! Just to keep you informed, unfortunately the conflict between UD and Temporary Container add-ons... still is there. Anyway, zillions of thanks for your fantastic work. Big hug! : )

ThomazPom commented 8 months ago

Hi I tested multiple, and i can't reproduce this issue.

ThomazPom commented 8 months ago

Can't reproduce, closing