ThomazPom / Moz-Ext-UltimaDark

Web Extension that uses agressive technique to get dark mode everywhere
12 stars 3 forks source link

Improper handling of legacy sites resulting in bright backgrounds #39

Closed Vintagemotors closed 5 months ago

Vintagemotors commented 6 months ago

Example site: https://www.sillycycle.com/abacus.html edit: background fixed in 1.5.37 now has contrast text issue (presumed html4 site) edit: still has contrast text issue in 1.5.38

I will edit this to add more if I find others. Edit: adding https://www.flashflashrevolution.com/ - 2.1m registered users. edit: fixed on first load falls to base html on page refresh Suggested behavior: disable image background and replace with background color from configuration chart or just a dark color.

Other than this your extension is nearly twice as fast as dark reader on first run for Speedometer 2.0 so well done!

ThomazPom commented 6 months ago

You are correct; I haven't yet made a decision regarding HTML4 legacy websites. I'm torn between transforming outdated tags from https://www.htmlhelp.com/reference/html40/deprecated.html into HTML5 tags or persisting in attempting to edit their color, which doesn't always prove effective as your examples shows.

I appreciate your comment about the load speed of UltimaDark, which I wasn't aware of. This is excellent news, as I had presumed UltimaDark might be slower due to the advanced techniques I mentioned in the ReadMe.md of this GitHub repository.

Vintagemotors commented 6 months ago

As an intermediary measure you could also consider creating a custom .css file to fallback on in cases where it is unable to change the color with your new methods. https://stackoverflow.com/questions/3099326/what-the-difference-between-the-support-for-css-by-html4-0-and-xhtml1-0

Vintagemotors commented 5 months ago

Fixed some time around 1.5.44