ThomazPom / Moz-Ext-UltimaDark

A web extension that uses aggressive techniques to enable dark mode on every site.
136 stars 6 forks source link

Broken Fonts Report (Priority level: High) #7

Open EstherMoellman opened 4 years ago

EstherMoellman commented 4 years ago

At: https://i.reddit.com/r/FirefoxCSS/comments/hxybh7/can_someone_help_a_noob_i_just_installed_the/.compact

if you click the image link: https://i.redd.it/0efowtlou3d51.png

Then the message appears: The image "https://i.redd.it/0efowtlou3d51.png" cannot be displayed because it contains errors.

If you disable UltimaDark... everything works fine. I also tested same link on www.reddit and old.reddit, and the issue still appears when UltimaDark is enabled.

FIXED V1.2.6

ThomazPom commented 4 years ago

A lot of contrast issues you may encounter for the time being are due to a whole part of the code that i disabled to work on others issues.

ThomazPom commented 4 years ago

https://tpeweb.paybox.com/cgi/MYpagepaiement.cgi FIXED V1.2.5 REGRESSION V.1.2.6 FIXED V1.2.8

EstherMoellman commented 4 years ago

https://www1.folha.uol.com.br/colunas/demetriomagnoli/2017/11/1936380-partidos-que-investem-em-huck-apostam-no-golpe-do-outsider.shtml https://www1.folha.uol.com.br/opiniao/2017/11/1936382-regulamento-pode-desvirtuar-nova-lei-de-migracao.shtml

https://www.linguee.fr/anglais-francais/traduction/one+at+a+time+or+all+at+once.html

barolo commented 7 months ago

This is still an issue, anything with Cyrillic script [like Ukrainian] gets converted into garbage. Latest Firefox.

Screenshot_20240423_221735

barolo commented 7 months ago

Also broken on some Polish sites, for example: https://trojmiasto.wyborcza.pl/trojmiasto/0,0.html Screenshot_20240424-025741646

Vintagemotors commented 5 months ago

Looks like an ANSI encoding issue. (Not really a font issue though since the font itself looks fine)

Vintagemotors commented 3 months ago

I don't speak either language but I spot checked text on the site you linked and a national Ukrainian news site with google translate and the style appeared to be consistent throughout without any weird encoding like you saw there - again assuming it was something to do with ANSI to UTF-8 not being handled properly or some other semi-proprietary encoding scheme causing a conflict (as of 1.5.50) @barolo

barolo commented 3 months ago

I don't speak either language but I spot checked text on the site you linked and a national Ukrainian news site with google translate and the style appeared to be consistent throughout without any weird encoding like you saw there - again assuming it was something to do with ANSI to UTF-8 not being handled properly or some other semi-proprietary encoding scheme causing a conflict (as of 1.5.50) @barolo

Unfortunately, as of 1.50.50 still an issue, all Polish letters with diactrics (like Ł, ł, ó, ź, ą, ę) are garbled with this add-on enabled. Screenshot_20240826-123710375

Vintagemotors commented 3 months ago

@barolo upon closer inspection of your screenshots which I initially assumed were taken using Firefox's "Responsive Design Mode" you appear to be on mobile which is highly experimental and unsupported. As stated in the wiki, it "somewhat works" with a single browser that (to my knowledge) isn't even published in any app stores. The flag which allows download from mobile is turned on for testing purposes but given how many features are missing from most mobile Firefox builds that UltimaDark relies on it will never be fully compatible unless mobile reaches feature parity. Please only submit issues for things that affect both desktop and mobile as many mobile only issues are essentially either unfixable or would take an unreasonable amount of work.

Screenshot(desktop) ![image](https://github.com/user-attachments/assets/930a24a7-de52-47dd-b325-57ef05e81873)
ThomazPom commented 1 month ago

1.5.71: I’ve fixed the issue with pages using non-UTF-8 charsets. Instead of forcing the page into UTF-8, which caused all kinds of issues, I now just let the page keep its original charset. I’m using a hacky but effective method to still write in UTF-8 without messing with the page’s encoding. This avoids the trouble of re-encoding into incompatible charsets. There’s still a potential issue if the page explicitly uses the charset keyword in CSS (not verified), or the content property in CSS (not verified), but this should be rare enough not to worry about.

I think it was the source of this issue too.

barolo commented 1 month ago

1.5.71: I’ve fixed the issue with pages using non-UTF-8 charsets. Instead of forcing the page into UTF-8, which caused all kinds of issues, I now just let the page keep its original charset. I’m using a hacky but effective method to still write in UTF-8 without messing with the page’s encoding. This avoids the trouble of re-encoding into incompatible charsets. There’s still a potential issue if the page explicitly uses the charset keyword in CSS (not verified), or the content property in CSS (not verified), but this should be rare enough not to worry about.

I think it was the source of this issue too.

Can confirm, fixed my issues.

ThomazPom commented 1 month ago

1.5.71 to 1.5.76 (current) were dedicated to fixing non utf8 websites. Fonts and CSSes are now loaded in their original encoding, eliminating the content keyword issue.

rr1231234 commented 3 weeks ago

https://www.wsj.com/ - first visit (or after a while) shows the slightly wrong font (wider than normal) but hitting F5 will fix it and showing the true font of that site