search

ThomazPom / Moz-Ext-UltimaDark

A web extension that uses aggressive techniques to enable dark mode on every site.
126 stars 6 forks source link

links in advanced settings #74

Closed atomGit closed 9 months ago

atomGit commented 9 months ago

the github links in the advanced settings open those pages in the pop-up instead of a tab

also atomGit link should probably be removed

Vintagemotors commented 9 months ago

Doesn't open in a popup for me on 1.5.36 or 1.5.37. What Firefox version are you on?

Vintagemotors commented 9 months ago

You can edit line 61 and submit a PR if you want to remove yourself https://github.com/ThomazPom/Moz-Ext-UltimaDark/blob/76919acd6f39ff1b75e9b80d68c8b7ac1ab8a792/popup.html#L61 otherwise mention @ ThomazPom

atomGit commented 9 months ago

Doesn't open in a popup for me on 1.5.36 or 1.5.37. What Firefox version are you on?

v122 -- it's a pref then, probably having to do with opening links in the same tab perhaps, however i haven't noticed it in any other add-on links

@ThomazPom - you can remove the atomGit link in advanced settings please

ThomazPom commented 9 months ago

Next release will have this link removed.

Vintagemotors commented 9 months ago

Completed in 1.5.38