ThomazPom / Moz-Ext-UltimaDark

Web Extension that uses agressive technique to get dark mode everywhere
35 stars 3 forks source link

Contrast Text Issues Report (Priority level: High) #8

Open EstherMoellman opened 4 years ago

ThomazPom commented 4 years ago

Note; Must intercept javascript styles

Better contrast with a new rgba mode

ThomazPom commented 4 years ago

https://edition.cnn.com/2019/07/07/africa/stella-nyanzi-as-equals-intl/index.html was a regression from 1.1.4 to 1.1.5 fixed in 1.1.6

baka24 commented 4 years ago

same as www.kaskus.co.id, original article is white background with black text, when UltimaDark enabled, is hard to see font from title article Screenshot


@baka24 , this seems to be fixed in v1.2.0. Please confirm. Thank you!


Fixed ! Thank you very much.

ThomazPom commented 4 years ago

@baka24 @EstherMoellman Altough contrast is getting better, a lot of contrast issues are due to a part of ultimadark i disabled on purpose.

ThomazPom commented 4 years ago

1.2.5 is online, it fixes regressions. More important it fixes broken fonts by selecting the right decoder for each page. I though it was linked to the broken pictures issues, but i was wrong

EstherMoellman commented 4 years ago

Original article text background is white, with black text. UltimaDark makes background transparent + black text... difficult to read: https://edition.cnn.com/2019/07/07/africa/stella-nyanzi-as-equals-intl/index.html EDIT - UPDATE: Fixed in V1.1.6 EDIT - UPDATE: Regression V1.2.2 FIXED.

https://www.ultimoinstante.com.br/ https://www.ultimoinstante.com.br/ultimas-noticias/por-ordem-do-stf-twitter-bloqueia-contas-de-roberto-jefferson-e-bolsonaristas-2/326751/ EDIT - UPDATE: Fixed in V1.2.0 REGRESSION V1.2.4 FIXED V1.2.5

https://www.facebook.com/ FIXED V.1.2.3 REGRESSION V1.2.4 FIXED V1.3.1

EstherMoellman commented 4 years ago

https://www.craigslist.org/about/sites#US

Vintagemotors commented 7 months ago

I suppose this belongs here too: https://manjaro.org/

Vintagemotors commented 7 months ago

https://tools.pingdom.com/

Vintagemotors commented 7 months ago

https://gt.dev/prime edit: resolved in 1.5.37

Vintagemotors commented 7 months ago

https://www.techingredients.com/thermalproducts text is the same color as the background.

ThomazPom commented 7 months ago

https://www.techingredients.com/thermalproducts text is the same color as the background. Easy to fix, featured in 1.5.34

ThomazPom commented 7 months ago

https://gt.dev/prime

Image edition bug https://graphite.dev/images/home/hero/background-mobile.jpg

ThomazPom commented 7 months ago

https://tools.pingdom.com/

https://tools.pingdom.com/

rgb(255, 240, 0) defalt color becomes rgb(204, 192, 0) with current settings of ultimaDark ( max background brightness 0.4 )

RGB 204, 192, 0 = HSL 56°, 100%, 40% is within the range

Therefore is not a bug, this is a decision to take : Decreasing default max background brightness without killing the colors. image image

Vintagemotors commented 7 months ago

for the https://tools.pingdom.com/ case it would be fine if the background isn't darkened further so long as the text can be changed to black where it is currently a light grey on the yellow background.

Vintagemotors commented 7 months ago

https://forums.extremeoverclocking.com/showthread.php?t=317935

ThomazPom commented 7 months ago

This is a legacy website issue (HTML4) not currently supported by UD

ThomazPom commented 7 months ago

For the https://tools.pingdom.com/ case it would be fine if the background isn't darkened further so long as the text can be changed to black where it is currently a light grey on the yellow background.

This is not possible. Backgrounds and text colours are not linked at all. Given that, the only pragmatic thing we can do is lowering the lightness of backgrounds and increase lightness of texts to achieve sufficient contrast to read.

Vintagemotors commented 7 months ago

This is a legacy website issue (HTML4) not currently supported by UD

Is adding HTML4 support in-scope?

ThomazPom commented 7 months ago

This is a legacy website issue (HTML4) not currently supported by UD

Is adding HTML4 support in-scope?

Yes!