search

ThomazPom / Moz-Ext-UltimaDark

A web extension that uses aggressive techniques to enable dark mode on every site.
126 stars 6 forks source link

Two issues, one is major (no video), the other is minor ([select] html element not rendering correctly) #84

Open aquarime opened 3 months ago

aquarime commented 3 months ago

Hi,

UltimaDark 1.5.50 with Firefox 115.14.0 ESR on Windows 7 I'll be establishing comparisons with the Dark Reader extension, not as a challenge but because Dark Reader is the extension I've used previously for darkening pages.

I'm facing 2 issues.

1- MAJOR ISSUE ------------------------------------------------------------

Video not rendering at all at https://www.livehdtv.com/bbc-news/ (all videos on that site to be precise) I've tried with Image Edition enabled as well as disabled : same issue

https://www.livehdtv.com/bbc-news/ with Dark Reader : video waiting to be started

2 1-DarkReader

https://www.livehdtv.com/bbc-news/ with UltimaDark: no video waiting logo, and clicking nevertheless has no effect:

2 2-UltimaDark

2- MINOR ISSUE ---------------------------------------------------------

Now this is special and perhaps specific to Windows 7 Ever since I started using an extension to darken pages I've encountered an issue regarding the handling of an HTML element called Select. Screenshots hereafter will explain it better than words I had found a CSS workaround to defeat the issue, which worked with the Dark Reader extension but not with the UltimaDark extension. The CSS that we'll call SELECT is:

select * {background: #C0C0C0 !important; color:#000 !important; opacity:1 !important;  text-shadow: none !important;} 
select:hover, select:focus-within {background: #C0C0C0 !important; color:#000 !important; opacity:1 !important; text-shadow: none !important;}

SELECT works with Dark Reader, but no longer with UltimaDark

Screenshots of a test page which includes the select html element, at https://www.uptrends.com/tools/uptime I've pasted them on a one-line background to make the comparisons easier.

1-Select

As shown, both Dark Reader and UltimaDark fail to render correctly the select html element, yet Dark Reader with the above-mentioned SELECT css fixes the issue.

Many thanks for your comments, advice, help

Vintagemotors commented 3 weeks ago

Confirmed UltimaDark is still breaking the JWPLAYER embed on 1.5.77. HTML SELECT appears to be fixed, though the dropdown is rendering with Firefox's dark theme select item instead of following the site's theming. Floorp 11.14.1 (ESR 115 core)

Vintagemotors commented 1 week ago

I confirmed JWPLAYER embed is still broken on 1.6.0 though HTML SELECT appears to be completely fixed.