search

Thomilist / dimensional-inventories

A Minecraft Fabric mod for keeping separate inventories across pools of dimensions.
https://modrinth.com/mod/dimensional-inventories
MIT License
2 stars 2 forks source link

Trinkets Support [1.20.1] #6

Open otowm opened 9 months ago

otowm commented 9 months ago

the itens in trinkets inventory dont disappear when passing the portals

NoPyro commented 9 months ago

This feature would also be nice for 1.19.2, trying to use Backpacked but it just remains in the inventory regardless, defeating the point.

Thomilist commented 9 months ago

I agree that modded inventory support would be valuable. Unfortunately, the mod currently suffers from being hacked together in a couple days and just polished slightly from there, meaning all the slots and effects that it saves and loads are hard-coded.

I'm tempted to scrap the current save/load implementation in favour of one that uses Minecraft's own, which it appears other mods tend to use as well. I'll have to do some digging and figure out how it works, but after that, it's just a matter of adding a trigger or two on dimension change. That should address not only Trinkets, but also Linked Storage (#5) and, I think, advancements (#4).

I assume automatic migration from the old to the new version would be a big plus as well. I can imagine manual migration being a bit of a pain if you have any more than a couple of players.

LordMaximus05 commented 8 months ago

Has there been any update to this issue? I am also having issues with trinkets and backpack slots not clearing.

Thomilist commented 8 months ago

The status is that it is expected behaviour with the current releases, though obviously not desirable. It's the top priority of the project, but progress is unfortunately slow for a few reasons: "real life" obligations, my inexperience with Minecraft modding, and my desire to solve this properly rather than implementing a mod-specific patch (which would give me the same issue again whenever support for a new mod is wanted, or possibly even if a previously-supported mod changes in a certain way). Sorry to disappoint :/

LordMaximus05 commented 8 months ago

no disappointment here! I know nothing about coding and so all of this is functionally magic to me lol take your time, its a very busy time of year and family/life comes first. But as a thought, (again I know nothing of coding) would it be possible to have like, a separate set of player data that is dimension specific? That way inventories, trinket slots, achievements etc are all separate.

LordMaximus05 commented 2 weeks ago

Sorry for Necro posting but did this ever get looked into? I really want this to work since there is no other way to get a creative dimension.

Thomilist commented 2 weeks ago

No worries. The recent rewrite was partly to support features like this more easily. So, yeah, I haven't forgotten about it, but it's been a long time, so it's completely fair to ask.

Still for 1.20.1, right?

LordMaximus05 commented 2 weeks ago

yes! Our server is 1.20.1 and we can't update to 1.20.4 because not all the mods are ready for that yet :)