search

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises
MIT License
1.9k stars 184 forks source link

added @discardableResult to andThen #158

Closed Noobish1 closed 7 years ago

Noobish1 commented 8 years ago

We use andThen similar to onSuccess and onFailure, we believe it should also have the @discardableResult decorator.

tdesert commented 7 years ago

Hi everyone,

Is it planned to merge this pull request soon? We do believe this is very useful to prevent all those Xcode warnings.

Thomvis commented 7 years ago

Let's discuss this some more in https://github.com/Thomvis/BrightFutures/issues/160.

oysta commented 7 years ago

Closing as discussed in #160 (use onComplete)