search

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises
MIT License
1.9k stars 184 forks source link

Swift4.0beta #169

Closed possen closed 7 years ago

possen commented 7 years ago

I don't know if others have already submitted this but since I did it for myself, thought I would push it back for others as your project is essential for a bunch of things I am working on. All the tests passed for me on all platforms. Something changed with the way Void parameters were handled in Swift 4. This was likely the only thing that may cause source changes for users of the project. So this may require that major version number needs to be bumped. Also, I am completely happy to make any changes you suggest.

Thank you so much for this project.

Thomvis commented 7 years ago

Thanks for your work and sorry for the long delay. I merged in your changes and confirmed they still work for Xcode 9b3. It has been released as part of 6.0.0-beta.1.

I'll add you as a contributor, to make it easier to help with the project in the future, if you want.

possen commented 7 years ago

Thank you!