Explicit Void return type on `analysis(ifSuccess:` block

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises

MIT License

1.9k stars 184 forks source link

Explicit Void return type on `analysis(ifSuccess:` block #184

Closed danj-stripe closed 6 years ago

danj-stripe commented 6 years ago

Fixes #183. The compile error in Xcode 9.3b4 is gone with this change, and it works in Xcode 9.2.

My understanding of https://bugs.swift.org/browse/SR-7059 is that Swift 4.1 is going to ship with this change being necessary.

Thomvis commented 6 years ago

Thanks for following up on this!

I'll send you an invite to become a collaborator on the project. Feel free to make a 6.0.1 release with this fix, if not I'll get to it later this week.