search

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises
MIT License
1.9k stars 184 forks source link

Xcode 10/Swift 4.2. Use Result 4.0.0 Fix #192 #193

Closed phimage closed 6 years ago

phimage commented 6 years ago

Just restoring missing function analysis removed from Result and fix value and error getters for new ResultProtocol implementation in Result 4.0.0

phimage commented 6 years ago

on travis same issue than previous PR maybe just minimum version for platform must edited in travis file

arnopoulos commented 6 years ago

@Thomvis Given the keynote next week do you think that this should be prioritized?

phimage commented 6 years ago

Hi, @Thomvis If you need help to manage project, you could add me. (You already add me to FutureProofing). Xcode 10 is out, and Result 4.0.0 is now used by other projects.

Thomvis commented 6 years ago

@phimage I've added you as a collaborator. Thanks for taking the time to help out. It would be great if you could spearhead the new Xcode 10 compatible release.

Thomvis commented 6 years ago

I've merged the PR into master and will cut a release shortly. Thanks for your help, and patience!