search

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises
MIT License
1.9k stars 184 forks source link

Upgrade Result dependency to 4+. #203

Closed Jeroenbb94 closed 5 years ago

Jeroenbb94 commented 5 years ago

Fixes #202

Thomvis commented 5 years ago

Thanks for your contribution!

I unfortunately think the change does not have the desired result. As per http://guides.cocoapods.org/using/the-podfile.html, ~> 4 means "any version of 4 and higher". This includes 5, 6, etc., which can introduce breaking changes. Instead, I think we want this to be ~> 4.0 or ~> 4.1.

Could you also remove the change of the version number. The next version number is determined not only by this PR, but also possible other changes pending for release.

When resolved, I'll gladly merge your work. Thanks again!