search

Thomvis / BrightFutures

Write great asynchronous code in Swift using futures and promises
MIT License
1.9k stars 184 forks source link

Fix Swift Version #209

Closed ShivaHuang closed 3 years ago

ShivaHuang commented 5 years ago

s.swift_version = '5' will produce SWIFT_VERSION = 5; in file project.pxproj, which keeps Xcode to prompt to convert to Swift 5. Setting s.swift_version = '5.0' fix this issue.

ShivaHuang commented 5 years ago

After some retry with unmodified podspec file, my Xcode stop prompting to convert BrightFutures to Swift 5. Can anyone confirm this?

My environment: macOS 10.14.5 Xcode 10.2.1 cocoapods 1.7.4

ShivaHuang commented 4 years ago

Will this PR be merged? Or should we just go for Swift 5.1?

Thomvis commented 3 years ago

This has been updated on master. Thanks!