Thomvis / Construct

Dungeons & Dragons DM companion app in SwiftUI
https://www.construct5e.app
MIT License
120 stars 5 forks source link

Improve readability of welcome screen on small screens. #6

Closed SpacyRicochet closed 3 years ago

SpacyRicochet commented 3 years ago

The features are hard to read on smaller device sizes (e.g. iPhone SE), since the scroll area is very small.

To alleviate this, the title is incorporated in the scroll view and the spacer above the button explanation as well. This leaves a larger scrollable area which results in a more pleasant reading experience.

Thomvis commented 3 years ago

Thanks for this. Your changes look good so I'll merge them in. I'll be making a minor adjustment to the padding/spacers. I don't think Spacers are valid to use in a ScrollView, i.e. their behavior is undefined. There's no error, so I might be wrong, but I can't reason about them.