search

Thorinair / Stardew-Profits

A Stardew Valley crop profits calculator and visualizer. Link: https://thorinair.github.io/Stardew-Profits/
MIT License
153 stars 74 forks source link

Fix issue of per day calculations being wrong for cross season crops #30

Closed mara-nel closed 3 months ago

mara-nel commented 3 years ago

The perDay function was originally dividing the value by the remaining number of days in the current season but those values were sometimes found including days from other seasons.

This change moves the remainingDays calculation from harvests() to be its own function which is then later called in valueCrops() and passed to the 3 perDay calls in it.

Thorinair commented 3 years ago

I will wait with accepting this one for now (I realize it has been many months, sorry xD), the newly big accepted PR resulted in some conflicts. However, maybe the new PR fixed the issues you encountered anyway, can you please check?

FinalDoom commented 3 years ago

I don't think I addressed this issue, but when I took a look, it looked like there was only one line/diff section that would be an issue. Should be a quick fix. Sadly it's a conflict that only came in later on, at first there were no conflicts XD

Oh I see Thorinair did some work to address it. I'll post back/edit here if it's something I can verify when I take a look through tonight.

FinalDoom commented 3 years ago

This looks to be fixed as far as I can tell with Thoirnair's changes for cross season stuff.

mara-nel commented 3 years ago

I think what I set out to fix may have been resolved with this, but currently a crop that can grow in spring, summer, and fall can only have information for two of those seasons shown. Depending on how that is resolved, this original issue might persist.

Thorinair commented 3 years ago

I do believe that it may now be fixed to be honest. The cross season stuff is now always limited to 56 days, but ONLY if actually possible. I would however indeed check if this works correctly before I discard anything. Possibly someone who is enough into the game right now to actually properly inspect it. :)