Thorinair / Stardew-Profits

A Stardew Valley crop profits calculator and visualizer. Link: https://thorinair.github.io/Stardew-Profits/
MIT License
153 stars 74 forks source link

Different fruit produce different amounts of wine when the number of kegs is the limiting factor. #76

Open Pluranium-Alloy opened 3 weeks ago

Pluranium-Alloy commented 3 weeks ago

Different fruit produce different amounts of wine when the number of kegs is the limiting factor.

2024-06-11 (1) 2024-06-11

Both crops produce significant amounts of excess fruit yet, somehow, the calculator shows that the ancient fruit produces almost twice as much wine as the starfruit despite that. According to the wiki, the time taken to produce wine does not vary based on what fruit you use so, since starfruit is more valuable, it should be more profitable if the number of kegs is the limiting factor (limiting number of kegs can be useful to simulate a limited number of casks as one keg can supply 8 casks).

doodlebunnyhops commented 3 weeks ago

In this case starfruit produces after 13 days and ancient fruit after maturity of 28 days regrows every 7 - thus ancient fruit would produce more. Given you have 108 crops spanning 7000 days the amount of crops produced is right.

However equipment isn't considering how long it takes to convert to said item. <- and would actually produce more excess crops unused in converting to an artisan item if time was factored. With only 16 kegs useable, 1 day to convert, and also assumes you can only use the keg on harvest, you would have ~8k keg items made from star fruit.

So the real ask is to update equipment with time factor to produce an artisan item.

Thorinair commented 3 weeks ago

Indeed, this behavior is expected, because the equipment is applied as per-harvest, and ignores the time it takes to process the crops. I agree that this is a limitation.

Implementing code to account for processing times would get extremely complicated, as this time varies on time of day when the crop was placed into the equipment, and some other factors. See the note here: https://stardewvalleywiki.com/Keg#Products It would also be an additional layer of code complication as you would have to somehow simulate each crop hour by hour and how it is harvested/processed.

Because of this, there are currently no plans to implement time calculations, unless someone adventurous enough feels like writing this complex code. One alternative that could be done is to add an option to do one big processing at the end of the season, similar to the option that currently exists for Dehydrators, but I don't think anyone processes all of the fruit at the end of the season, so it was never really considered.