Thorinair / Stardew-Profits

A Stardew Valley crop profits calculator and visualizer. Link: https://thorinair.github.io/Stardew-Profits/
MIT License
168 stars 82 forks source link

"Pay For Seeds" estimates seed cost improperly for plants which have multiple harvests #91

Open americobarros opened 4 hours ago

americobarros commented 4 hours ago

Love this tool!

Edit: See comments for updated issue.

I noticed though that the "Pay For Seeds" option seems to use the quantity sold to calculate seed cost, rather than the number planted. This causes an over estimation of seed cost.

For example, below I said that I had 16 crops of pumpkins planted on the first day. This would result in needing 16 pumpkin seeds (since they can be harvested multiple times) and would produce 32 harvests/pumpkins. At $100 per seed, the total cost of the seeds would be $1600. Instead, it is calculated as $3200. Heres a link to the full results

image
americobarros commented 4 hours ago

Sooo I totally read the wiki wrong, and even tho it looks like it, pumpkins do NOT regrow 🤦 The seed cost is calculated using whether or not they regrow however, there IS a discrepancy between the Planted variable and the Seed Loss variable which caused me to make this error.

Seed Loss assumes you plant 16 crops, and then replant them before the end of the month using new seeds. 32 seeds x 100 = $3200 Planted seems to only use the Number of Crops -> therefore 16 seeds 16 seeds x 100 = $1600

Replanting new seeds should be used to calculate the number planted. Clarity wise, the Planted variable could be changed to seeds needed for clarity.