Thorium-Sim / thorium

Platform for starship simulator controls
https://thoriumsim.com
Apache License 2.0
157 stars 69 forks source link

Manually Setting Alert Condition Colors #3274

Open Horizon-Storm opened 1 year ago

Horizon-Storm commented 1 year ago

The feature request is to create more variety in the layouts. The goal is to help us have different layouts easily without having to program a new layout. An example is the Falcon at the Christa McAuliffe Space Center is looking to get an adjusted version of Epsilon to use. Mr. Porter the Set Director does not want to have blue on the ship. Instead of programming an identical layout with color changes this proposal will allow us to make changes to the colors without having to program new layouts. This can also allow us to make changes to the colors on the layout similar to what Epsilon already has without hard coding it in. The goal is to provide versatility and easy adjustments to help make Thorium easier to use.

The Solution that was presented is having a color slider to manually adjust the colors of the assets. For Epsilon it would adjust the buttons you press to change alert levels as well as the lines on the sides of the screens. You can then set things like an orange Alert 5. The goal for the Falcon is more alert conditions that match our set. Ideally it may be possible to implement on all SVG based layouts. However testing it on Epsilon is my specific request to see if it works. If it does then it can be pushed so more layouts can use the code and give us even more layout options.

It will only change the alert level colors all other colors on the layout will remain the same.

alexanderson1993 commented 1 year ago

Where would that color slider exist? On the ship config, where you configure the layout for your ship before a flight?

Would it be possible to set separate colors for each alert condition on a per-layout basis?

Frankly, this sounds like a one-off situation, and duplicating the Epsilon layout and adjusting the colors makes more sense to me.

Horizon-Storm commented 1 year ago

The color slider would be in the ship config screen. It would be possible to set the layout color per simulator not layout since it is looking at the simulator. It opens up more possibilities for ships like the Galileo that become other ships and don't use other Alert Conditions to be able to very specifically change that. I also know that the Galileo has their ship permanently at 4. I am sure the ability to make it so their alert 5 is green would be utilized there. (they use the black layout). I have already looked into just changing Epsilon but it would be better for the long run to have this ability to adjust so we don't have just more and more duplicate layouts.

On Thu, Mar 23, 2023 at 6:08 PM Alex Anderson @.***> wrote:

Where would that color slider exist? On the ship config, where you configure the layout for your ship before a flight?

Would it be possible to set separate colors for each alert condition on a per-layout basis?

Frankly, this sounds like a one-off situation, and duplicating the Epsilon layout and adjusting the colors makes more sense to me.

— Reply to this email directly, view it on GitHub https://github.com/Thorium-Sim/thorium/issues/3274#issuecomment-1482072278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFS52JH7ENCSFMXSBEUYNTW5TQZXANCNFSM6AAAAAAWFZTSEY . You are receiving this because you authored the thread.Message ID: @.***>

Trajkov commented 1 year ago

Below is a short video proposal to demonstrate the intended functionality: https://youtu.be/7K9vF45HiJ8

alexanderson1993 commented 1 year ago

Thanks for the video demo. I can get behind this.

A few thoughts

The goal here is to make this an incremental change, so folks upgrading don't experience any breaking changes to how things work.

As an aside: This feature won't be necessary in Thorium Nova because themes are implemented as part of plugins, and aren't hard-coded. That means any user can write CSS (actually LESS, with TailwindCSS support built in), upload images and fonts, etc. to create a custom theme. Creating a theme with custom alert colors would involve duplicating an existing layout, changing the color variables... and that's it.