Job Gift spells should always pass addendum check

ThornyFFXI / tHotBar

Macro binding interface for keyboard users in FFXI.

MIT License

5 stars 2 forks source link

Job Gift spells should always pass addendum check #4

Closed mousseng closed 12 months ago

mousseng commented 12 months ago

After unlocking Utsusemi: San I noticed it was always faded, and tracked that down to the difference between MainJobCheck() and JobPointCheck() in the spell updater.

As far as I'm aware no Job Gift spells are affected by addendums, so I've just got it always returning true. If this is a faulty assumption, I'm happy to mimic the logic performed by MainJobCheck() instead (or whatever is appropriate).

ThornyFFXI commented 12 months ago

Your interpretation and patch are correct, if you'd like me to directly merge your commit you'll need to increase the version by 0.01 so that it is not identically numbered. Otherwise, I can certainly make a new commit myself.