search

ThornyFFXI / tHotBar

Macro binding interface for keyboard users in FFXI.
MIT License
6 stars 2 forks source link

Palette Change Crashes #7

Open Erroley opened 9 months ago

Erroley commented 9 months ago

When trying to do a /tb palette change "name" I keep getting random game crashes. Do the palette names need to contain no spaces so I can exclude the quotes around it, or should it not be crashing when I use that command when spaces are in the palette name?

ThornyFFXI commented 9 months ago

The palette names shouldn't matter, and can contain spaces. If the entire game is crashing, that's indicative of a deeper problem, and while it may potentially be outside the scope of tHotBar (running out of ram,vram for instance), more info is needed to diagnose:

-Does it crash every time you change palettes, or just occasionally? -Does it happen more often around a certain palette change? -Are you changing palettes with a thotbar macro? If so, what is the macro you're using to change, and what's the macro on the same slot in the palette you're changing to? -Is there any sort of error message or does the game just close outright?

Erroley commented 9 months ago

-Does it crash every time you change palettes, or just occasionally? No, it is random. Mostly notice it within my first 30 minutes of playing

-Does it happen more often around a certain palette change? It happens regardless of the palette change using thotbar keybind as command.

-Are you changing palettes with a thotbar macro? If so, what is the macro you're using to change, and what's the macro on the same slot in the palette you're changing to? I have the macro commands to change palettes on a job global bar. It is changing out a different row for the palette change.

Here is an example of one of the palette changes lua:

["1"] = { ActionType = 'Command', Macro = T{ "/tb palette change \"Debuffs Ele\"", }, Label = "Debuffs Ele", Image = "jobs/smn.png", ShowCost = false, ShowCross = false, ShowFade = false, ShowRecast = false, ShowName = true, ShowTrigger = true, ShowSkillchainIcon = false, ShowSkillchainAnimation = false, ShowHotkey = true, },

-Is there any sort of error message or does the game just close outright? When this happens the game crashes and closes 90% of the time. The other 10% of the times it locks the game up.

ThornyFFXI commented 9 months ago

I will look into it, but reproducing something like this can be tricky because it isn't likely to be anything inherent to the addon, so it will likely not have an immediate resolution.

Erroley commented 9 months ago

Thank you and I understand. I'm a Lead Developer so I know how it is :)

Erroley commented 9 months ago

Do you think it could be because I had around 100 binds? Wondering if that maybe causes a memory issue.

ThornyFFXI commented 9 months ago

I would assume not.. textures should be cached and everything else is relatively small. I am thinking something more like a flaw in the underlying lua interpreter causing a stack overflow when reassigning everything. But, tracing something like that would be close enough to impossible without a crash dump or the ability to reproduce it on my machine.

ThornyFFXI commented 2 months ago

Just an update, it seems likely this is the same issue here: https://github.com/ThornyFFXI/tCrossBar/issues/16

We did receive a crash dump in the Ashita channel, and found that crash to be happening inside d3d8 / graphics driver calls. From the best I can tell, it is not a problem originating inside the addon's code or the lua engine itself, and I could not reproduce it even with extremely strenuous tests on my own machine(linked in that issue thread).

If anyone has any further information or a way to reliably reproduce this crash, I am open to trying things. I'd also request sharing macro sets that are known to cause this problem for others, they are located at: Ashita/config/addons/thotbar/charname_charid/bindings/globals.lua and Ashita/config/addons/thotbar/charname_charid/bindings/job.lua

Ebonhawk3829 commented 1 week ago

Hi Thorny, Sorry its not reliable, but I've been experiencing this crash, suddenly starting today, sporadically.

Things of note:

Other details:

LUAs https://pastebin.com/68dzDtxe

ThornyFFXI commented 1 week ago

The original crash described was tied to changing palettes, not simply activating macros. Unfortunately, at this point in time, it has been completely unreproducible and that continues to be the case when attempting to cause a crash using your own macro files.

I am forced to conclude this is a hardware issue, if you have a 13th or 14th gen intel CPU that would be the most likely cause and users in the ashita discord have had success resolving similar issues with HXUI by underclocking and/or undervolting.