the changes here below are very important and are for your consideration.
The bump calculated inside the routine getOrbitBump in SCBBA used zeros as reference. The problem with this method is that the orbit gets corrected to zeros when applying the CMvec values.
Instead, the reference orbit should be the closed orbit read by the BPMs, and the BBABPMtarget value should be added to it.
This allows to calculate a set of correctors that preserves the closed orbit within the BPM errors including the desired offset at the target BPM.
Dear Thorsten,
the changes here below are very important and are for your consideration.
The bump calculated inside the routine getOrbitBump in SCBBA used zeros as reference. The problem with this method is that the orbit gets corrected to zeros when applying the CMvec values.
Instead, the reference orbit should be the closed orbit read by the BPMs, and the BBABPMtarget value should be added to it. This allows to calculate a set of correctors that preserves the closed orbit within the BPM errors including the desired offset at the target BPM.
I reported it early last year in this issue : https://github.com/ThorstenHellert/SC/issues/22
Best regards, o